Introduce Reactor MonoJustRepeatTakeOne Refaster rule #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. No mutations were possible for these changes. |
|
rickie
reviewed
Jul 17, 2024
| @@ -1727,6 +1727,19 @@ PublisherProbe<T> after() { | |||
| } | |||
| } | |||
|
|
|||
| /** Prefer {@link Flux#just(Object)} over more verbose alternatives. */ | |||
| static final class MonoJustRepeatTakeOne<T> { | |||
There was a problem hiding this comment.
We have a undocumented rule about the naming of Refaster rules, we name them like the content of their after template. In this case that would clash with the already existing FluxJust Refaster rule, didn't know that was already there.
That changes some things a little bit;
- We can move this rule up a bit to be together with that one. We should rename the other one then as that has a limitation that it only works for
Integers. - Didn't see this upfront, but I think we can combine the two rules into one! Let's take a look together tomorrow @tijana-ninkovic :).
| @@ -584,6 +584,10 @@ ImmutableSet<PublisherProbe<Void>> testPublisherProbeEmpty() { | |||
| return ImmutableSet.of(PublisherProbe.of(Mono.empty()), PublisherProbe.of(Flux.empty())); | |||
| } | |||
|
|
|||
| Flux<Integer> testMonoJustRepeatTakeOne() { | |||
| return Mono.just(5).repeat().take(1); | |||
There was a problem hiding this comment.
Within each test, we usually start with value 0 and go up from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the
MonoJustRepeatTakeOnerule, which replaces the following patternwith
Suggested Commit Message