Have RefasterTemplateCollection verify template test class names
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
force-pushed
the
sschroevers/validate-template-test-class-names
branch
from
a604b35
to
32a4716
Compare
Stephan202
force-pushed
the
sschroevers/validate-template-test-class-names
branch
from
32a4716
to
8323250
Compare
rickie
approved these changes
Sep 28, 2022
| } | ||
| } | ||
|
|
||
| // This is a comment to appease CheckStyle. |
There was a problem hiding this comment.
Suggested change
| // This is a comment to appease CheckStyle. | |
| // This is a comment to appease Checkstyle. |
Also below 😉.
For when we get back to this PR.
| describeMatch( | ||
| typeDeclaration, | ||
| SuggestedFix.prefixWith( | ||
| typeDeclaration, "/* ERROR: Unexpected declaration. */\n"))); |
There was a problem hiding this comment.
Suggested change
| typeDeclaration, "/* ERROR: Unexpected declaration. */\n"))); | |
| typeDeclaration, "/* ERROR: Unexpected token. */\n"))); |
Would "token" be more accurate, according to the docs of getTypeDecls:
* The list may also include empty statements resulting from
* extraneous semicolons.
There was a problem hiding this comment.
I like token 👍. Rebased and added a commit.
Stephan202
force-pushed
the
sschroevers/validate-template-test-class-names
branch
from
b342377
to
0e0fff7
Compare
|
Build failed due to a read timeout connecting to Jitpack. Also affected the most recent build on |
ferdinand-swoboda
approved these changes
Sep 29, 2022
Stephan202
force-pushed
the
sschroevers/validate-template-test-class-names
branch
from
0e0fff7
to
c1e8bb6
Compare
|
Rebased and the build now passed. Tnx for the extra review @ferdinand-swoboda! Will merge. |
Stephan202
deleted the
sschroevers/validate-template-test-class-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here.
Suggested commit message: