Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update XXX comments to reference google/error-prone#2706 #249

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Update XXX comments to reference google/error-prone#2706 #249

merged 2 commits into from
Sep 21, 2022

Conversation

rickie
Copy link
Member

@rickie rickie commented Sep 20, 2022

I think it'd be nice to update these XXX's for clarity.

These changes would have been part of #46 but we didn't merge that one because we don't want to have incompatibilities with the original Error Prone.

@rickie rickie added the documentation A documentation update label Sep 20, 2022
@rickie rickie added this to the 0.4.0 milestone Sep 20, 2022
@rickie rickie changed the title Update XXX's relating to missing type arguments to reference #2706 Update XXX's relating to missing type arguments to reference error-prone#2706 Sep 20, 2022
Stephan202
Stephan202 approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and added an OCD commit. Suggested commit message:

Update `XXX` comments to reference google/error-prone#2706 (#249)

@Stephan202 Stephan202 force-pushed the rossendrijver/update_docs_type_argument_missing branch from f0fa0b0 to 3da92da Compare September 20, 2022 20:38
@rickie rickie changed the title Update XXX's relating to missing type arguments to reference error-prone#2706 Update XXX comments to reference google/error-prone#2706 Sep 21, 2022
@rickie rickie merged commit 43bcbea into master Sep 21, 2022
@rickie rickie deleted the rossendrijver/update_docs_type_argument_missing branch September 21, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

@svavahb svavahb svavahb approved these changes

Assignees
No one assigned
Labels
documentation A documentation update
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rickie @Stephan202 @svavahb