Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply small README improvements #266

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Apply small README improvements #266

merged 4 commits into from
Sep 28, 2022

Conversation

sandermak
Copy link
Member

No description provided.

README.md Outdated
@@ -139,10 +139,11 @@ Two things are kicking in here:
Be sure to check out all [bug checks][bug-checks] and [refaster
templates][refaster-templates].

## 👷 Building
## 👷 Building Error Prone Support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we like to repeat the project's name? If it's preferred, should we also update below? e.g. How Error Prone Support works?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in Slack:

.. to clearly indicate we're switching from showing the tool in action (section above) to talking about the project itself.

On my first read, it seemed like the Building section was still about the example that is explained just above. Instead, we switch to documentation about the project itself. Open to other suggestions to make this distinction clearer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already an H1 (along with a nice emoji), so that should conceptually separate it.

However, I do see your point.

Alternatives:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ps. if changing, we need to update the anchor (line 23)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like Developing Error Prone Support, will update. Including anchor, good point.

Copy link
Member

@japborst japborst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

README.md Outdated Show resolved Hide resolved
@Stephan202 Stephan202 added this to the 0.4.0 milestone Sep 28, 2022
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx! Rebased and added a commit.

Suggested commit message:

Apply small README improvements (#266)

README.md Outdated
Comment on lines 11 to 13
Error Prone Support is a [Picnic][picnic-blog]-opinionated extension of Google's
[Error Prone][error-prone-orig-repo]. It aims to improve code quality, focussing
on maintainability, consistency and avoidance of common pitfalls.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping, whitespace at end of lines 👀

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR :).

@rickie rickie changed the title Small README suggestions Apply small README improvements Sep 28, 2022
@rickie rickie merged commit 50970eb into master Sep 28, 2022
@rickie rickie deleted the sandermak/readme-updates branch September 28, 2022 15:21
@rickie rickie added the documentation A documentation update label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation A documentation update
Development

Successfully merging this pull request may close these issues.

None yet

4 participants