Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename package tech.picnic.errorprone.refaster.{util => matchers} #267

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Rename package tech.picnic.errorprone.refaster.{util => matchers} #267

merged 1 commit into from
Sep 29, 2022

Conversation

rickie
Copy link
Member

@rickie rickie commented Sep 28, 2022 •
edited

Suggested commit message:

Move `Matcher`s in `refaster-support` from `.util` to `.matchers` package (#267)

@rickie rickie added this to the 0.4.0 milestone Sep 28, 2022
Stephan202
Stephan202 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative suggested commit message:

Rename package `tech.picnic.errorprone.refaster.{util => matchers}` (#267)

@Stephan202 Stephan202 mentioned this pull request Sep 28, 2022
Merged
Badbond
Badbond approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@Badbond Badbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested commit message also LGTM 👍

@rickie rickie changed the title Move Matchers in refaster-support from .util to .matchers package Rename package tech.picnic.errorprone.refaster.{util => matchers} Sep 29, 2022
@rickie rickie merged commit 5b079ee into master Sep 29, 2022
@rickie rickie deleted the rossendrijver/move_matchers branch September 29, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

@Badbond Badbond Badbond approved these changes

Assignees
No one assigned
Labels
improvement
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rickie @Stephan202 @Badbond