Extend MonoFlux Refaster rule
#358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickie
requested review from
rickie and
Stephan202
and removed request for
rickie
rickie
approved these changes
Nov 19, 2022
There was a problem hiding this comment.
Rebased and added a commit.
Nice addition @werli 🚀!
Tried to think of other possible variants but couldn't think of them.
Alternative suggested commit message (or we should just use the already proposed one 🤔):
Have `MonoFlux` flag `Mono#FlatMapMany(Flux::just)` cases
| @@ -559,7 +559,7 @@ Flux<S> after(Flux<T> flux) { | |||
| static final class MonoFlux<T> { | |||
| @BeforeTemplate | |||
| Flux<T> before(Mono<T> mono) { | |||
| return Flux.concat(mono); | |||
| return Refaster.anyOf(Flux.concat(mono), mono.flatMapMany(Flux::just)); | |||
There was a problem hiding this comment.
We usually list Monos before Fluxes, so will change the order :).
rickie
force-pushed
the
werli/mono-flux-just
branch
from
d03eae3
to
600963f
Compare
Stephan202
approved these changes
Nov 19, 2022
| @@ -559,7 +559,7 @@ Flux<S> after(Flux<T> flux) { | |||
| static final class MonoFlux<T> { | |||
| @BeforeTemplate | |||
| Flux<T> before(Mono<T> mono) { | |||
| return Flux.concat(mono); | |||
| return Refaster.anyOf(mono.flatMapMany(Flux::just), Flux.concat(mono)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I had noticed during code review. 👍
Suggested commit message