Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve IdentityConversion check #407

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Improve IdentityConversion check #407

merged 1 commit into from
Dec 21, 2022

Conversation

Stephan202
Copy link
Member

Resolves an issue found while testing Error Prone Support against Checkstyle (currently testing on this branch).

Suggested commit message:

Improve `IdentityConversion` check (#407)

If the result of an explicit boxing operation is immediately
dereferenced, then the explicit conversion operation is not redundant.

@Stephan202 Stephan202 added this to the 0.7.0 milestone Dec 11, 2022
@github-actions
Copy link

Looks good. All 6 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.IdentityConversion 0 6

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions
Copy link

Looks good. All 6 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.IdentityConversion 0 6

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 mentioned this pull request Dec 11, 2022
Merged
@rickie rickie force-pushed the sschroevers/IdentityConversion-improvements branch from a69a7b3 to ce3dc14 Compare December 19, 2022 15:03
@github-actions
Copy link

Looks good. All 6 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.IdentityConversion 0 6

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie
rickie approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty fun edge case. Fix looks good to me.

@Stephan202 @rickie
Improve IdentityConversion check
a347980 
If the result of an explicit boxing operation is immediately
dereferenced, then the explicit conversion operation is not redundant.
@rickie rickie force-pushed the sschroevers/IdentityConversion-improvements branch from ce3dc14 to a347980 Compare December 21, 2022 08:37
@rickie rickie added the bug fix label Dec 21, 2022
@rickie
Copy link
Member

rickie commented Dec 21, 2022

Hmm, is this an improvement or a bug fix?

@github-actions
Copy link

Looks good. All 6 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.IdentityConversion 0 6

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member Author

Stephan202 commented Dec 21, 2022 •
edited
Loading

  • Label-wise: bug fix 👍
  • Suggested commit message-wise: would leave as-is.

@rickie
Copy link
Member

rickie commented Dec 21, 2022

Ah yes I only meant label-wise 😄. Nice.

@rickie rickie merged commit 5665470 into master Dec 21, 2022
@rickie rickie deleted the sschroevers/IdentityConversion-improvements branch December 21, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chamil-prabodha chamil-prabodha chamil-prabodha approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
bug fix
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stephan202 @rickie @chamil-prabodha