Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce StreamIterate Refaster rule #762

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Introduce StreamIterate Refaster rule #762

merged 1 commit into from
Aug 29, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Aug 25, 2023 •
edited

Suggested commit message:

Introduce `StreamIterate` Refaster rule (#762)

@Stephan202 Stephan202 added this to the 0.13.0 milestone Aug 25, 2023
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie modified the milestones: 0.13.0, 0.14.0 Aug 25, 2023
@rickie
Copy link
Member

rickie commented Aug 28, 2023

I'd say we don't want to include this in the 0.13.0 release as we already finished downstream validation? I propose to do the release and start merging PRs afterwards again :).

(OTOH I don't see a big risk in this Refaster rule, but still...)

@Stephan202
Copy link
Member Author

Either works for me 👍

@Stephan202 Stephan202 modified the milestones: 0.13.0, 0.14.0 Aug 28, 2023
@Stephan202 Stephan202 force-pushed the sschroevers/introduce-StreamIterate branch from 7ef5d28 to 978e4bc Compare August 29, 2023 06:49
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rickie rickie merged commit 7779631 into master Aug 29, 2023
17 checks passed
@rickie rickie deleted the sschroevers/introduce-StreamIterate branch August 29, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

Assignees
No one assigned
Labels
new feature
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stephan202 @rickie @mohamedsamehsalah