Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce StreamOf{1,2,3,4,5} Refaster rules #814

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Introduce StreamOf{1,2,3,4,5} Refaster rules #814

merged 2 commits into from
Oct 11, 2023

Conversation

Venorcis
Copy link
Contributor

@Venorcis Venorcis commented Oct 6, 2023 •
edited
Loading

Mainly occurs in tests, but making a list for streaming only is unnecessary (and more verbose) 🤷🏻‍♂️

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Stephan202
Stephan202 approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ImmutableList#of overloads aren't very friendly to the way in which Refaster works, thus requiring this kind of duplication in various places. At some point we should write a checker instead, but for now this SGTM :)

Rebased and added a commit. Suggested commit message:

Introduce `StreamOf{1,2,3,4,5}` Refaster rules (#814)

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableListRules.java Outdated Show resolved Hide resolved
error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableListRules.java Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Venorcis Venorcis requested a review from rickie October 11, 2023 07:18
@rickie rickie added this to the 0.15.0 milestone Oct 11, 2023
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rickie rickie merged commit 4e2ceeb into master Oct 11, 2023
17 checks passed
@rickie rickie deleted the vkoeman/collection-stream branch October 11, 2023 15:52
@Stephan202 Stephan202 changed the title Introduce ImmutableList.of().stream() Refaster rules Introduce StreamOf{1,2,3,4,5} Refaster rules Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
new feature
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Venorcis @Stephan202 @rickie