Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify AbstractMatcherTestChecker #853

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Simplify AbstractMatcherTestChecker #853

merged 1 commit into from
Nov 27, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Oct 23, 2023 •
edited
Loading

Suggested commit message:

Simplify `AbstractMatcherTestChecker` (#853)

By using `TreePathScanner` rather than directly using `TreeScanner`.

@Stephan202 Stephan202 added this to the 0.15.0 milestone Oct 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

mohamedsamehsalah
mohamedsamehsalah approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Left one question not related to this PR 👍

...pport/src/test/java/tech/picnic/errorprone/refaster/matchers/AbstractMatcherTestChecker.java Show resolved Hide resolved
@rickie rickie force-pushed the sschroevers/abstract-matcher-test-checker-improvements branch from e53ce13 to 3067dbd Compare November 27, 2023 08:09
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 @rickie
Simplify AbstractMatcherTestChecker
3842c5d 
By using `TreePathScanner` rather than directly using `TreeScanner`.
@rickie rickie force-pushed the sschroevers/abstract-matcher-test-checker-improvements branch from 3067dbd to 3842c5d Compare November 27, 2023 10:24
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rickie rickie merged commit 17c7b39 into master Nov 27, 2023
17 checks passed
@rickie rickie deleted the sschroevers/abstract-matcher-test-checker-improvements branch November 27, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
improvement
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stephan202 @rickie @mohamedsamehsalah