Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unnecessary dependency declarations #973

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Drop unnecessary dependency declarations #973

merged 1 commit into from
Jan 13, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Jan 13, 2024 •
edited
Loading

Suggested commit message:

Drop unnecessary dependency declarations (#973)

@Stephan202 Stephan202 added this to the 0.15.0 milestone Jan 13, 2024
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

mohamedsamehsalah
mohamedsamehsalah approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanest 🧹

I checked that I can run the tests of each module from intellij ✅

@rickie rickie force-pushed the sschroevers/drop-unnecessary-dependency-declarations branch from eed366e to 4156c50 Compare January 13, 2024 19:43
@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Jan 13, 2024
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 13, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Stephan202 Stephan202 merged commit dff67fe into master Jan 13, 2024
16 checks passed
@Stephan202 Stephan202 deleted the sschroevers/drop-unnecessary-dependency-declarations branch January 13, 2024 19:53
This was referenced Jan 13, 2024
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stephan202 @rickie @mohamedsamehsalah