Skip to content

Commit

Permalink
Fix duplications in codegen (#12)
Browse files Browse the repository at this point in the history
  • Loading branch information
@LcTwisk
LcTwisk committed Jan 10, 2020
1 parent 7f4a396 commit 7703c23
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 165 deletions.
6 changes: 5 additions & 1 deletion src/actions/render.js
View file
Expand Up @@ -21,8 +21,12 @@ const render = (data, outputPath, platforms, languages) => {
return [...acc, ...renderResults];
}, []);

const uniqueTranslations = Object.values(
translations.reduce((result, acc) => ({ ...result, [acc.keyPath]: acc }), {})
);

const codeGenerationRenders = platforms
.map(platform => [createCodeGenView(translations, platform), platform])
.map(platform => [createCodeGenView(uniqueTranslations, platform), platform])
.map(([view, platform]) => renderCodeGenView(view, platform, outputPath));

return [...localizationRenders, ...codeGenerationRenders]
Expand Down
164 changes: 0 additions & 164 deletions tests/actions/__snapshots__/render.test.js.snap
View file
Expand Up @@ -766,16 +766,6 @@ extension UILabel {
struct L {
struct Checkout {
struct OrderOverview {
static func Total(args: CVarArg...) -> LocaliciousData {
return LocaliciousData(
accessibilityIdentifier: \\"Checkout.OrderOverview.Total\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Checkout.OrderOverview.Total.COPY\\",
translationArgs: args
)
}
static func Total(args: CVarArg...) -> LocaliciousData {
return LocaliciousData(
accessibilityIdentifier: \\"Checkout.OrderOverview.Total\\",
Expand All @@ -796,16 +786,6 @@ struct L {
translationArgs: args
)
}
static func Subtotal(args: CVarArg...) -> LocaliciousData {
return LocaliciousData(
accessibilityIdentifier: \\"Checkout.OrderOverview.Subtotal\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Checkout.OrderOverview.Subtotal.COPY\\",
translationArgs: args
)
}
}
}
struct Settings {
Expand All @@ -818,22 +798,6 @@ struct L {
translationKey: \\"Settings.PushPermissionsRequest.Title.COPY\\",
translationArgs: []
)
static let Title = LocaliciousData(
accessibilityIdentifier: \\"Settings.PushPermissionsRequest.Title\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Settings.PushPermissionsRequest.Title.COPY\\",
translationArgs: []
)
static let Subtitle = LocaliciousData(
accessibilityIdentifier: \\"Settings.PushPermissionsRequest.Subtitle\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Settings.PushPermissionsRequest.Subtitle.COPY\\",
translationArgs: []
)
static let Subtitle = LocaliciousData(
accessibilityIdentifier: \\"Settings.PushPermissionsRequest.Subtitle\\",
accessibilityHintKey: nil,
Expand All @@ -858,14 +822,6 @@ struct L {
translationKey: \\"Something.With.An.Arbitrary.Amount.Of.Nesting.COPY\\",
translationArgs: []
)
static let Nesting = LocaliciousData(
accessibilityIdentifier: \\"Something.With.An.Arbitrary.Amount.Of.Nesting\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Something.With.An.Arbitrary.Amount.Of.Nesting.COPY\\",
translationArgs: []
)
}
}
}
Expand All @@ -874,16 +830,6 @@ struct L {
}
struct Delivery {
struct Widget {
static func Title(args: CVarArg...) -> LocaliciousData {
return LocaliciousData(
accessibilityIdentifier: \\"Delivery.Widget.Title\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Delivery.Widget.Title.COPY\\",
translationArgs: args
)
}
static func Title(args: CVarArg...) -> LocaliciousData {
return LocaliciousData(
accessibilityIdentifier: \\"Delivery.Widget.Title\\",
Expand All @@ -905,25 +851,6 @@ struct L {
translationArgs: args
)
}
static func SubTitle(quantity: Int, args: CVarArg...) -> LocaliciousData {
let quantityType = LocaliciousQuantity(quanitity: quantity)
return LocaliciousData(
accessibilityIdentifier: \\"Delivery.Widget.SubTitle\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Delivery.Widget.SubTitle.COPY.\\\\(quantityType.rawValue)\\",
translationArgs: args
)
}
static let SpecialCharacters = LocaliciousData(
accessibilityIdentifier: \\"Delivery.Widget.SpecialCharacters\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Delivery.Widget.SpecialCharacters.COPY\\",
translationArgs: []
)
static let SpecialCharacters = LocaliciousData(
accessibilityIdentifier: \\"Delivery.Widget.SpecialCharacters\\",
accessibilityHintKey: nil,
Expand All @@ -940,25 +867,9 @@ struct L {
translationKey: \\"Delivery.Widget.MultilineStrings.COPY\\",
translationArgs: []
)
static let MultilineStrings = LocaliciousData(
accessibilityIdentifier: \\"Delivery.Widget.MultilineStrings\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Delivery.Widget.MultilineStrings.COPY\\",
translationArgs: []
)
}
}
struct Accessible {
static let RegularComponent = LocaliciousData(
accessibilityIdentifier: \\"Accessible.RegularComponent\\",
accessibilityHintKey: \\"Accessible.RegularComponent.ACCESSIBILITY.HINT\\",
accessibilityLabelKey: \\"Accessible.RegularComponent.ACCESSIBILITY.LABEL\\",
accessibilityValueKey: nil,
translationKey: \\"Accessible.RegularComponent.COPY\\",
translationArgs: []
)
static let RegularComponent = LocaliciousData(
accessibilityIdentifier: \\"Accessible.RegularComponent\\",
accessibilityHintKey: \\"Accessible.RegularComponent.ACCESSIBILITY.HINT\\",
Expand All @@ -978,17 +889,6 @@ struct L {
translationArgs: []
)
}
static func PluralComponent(quantity: Int) -> LocaliciousData {
let quantityType = LocaliciousQuantity(quanitity: quantity)
return LocaliciousData(
accessibilityIdentifier: \\"Accessible.PluralComponent\\",
accessibilityHintKey: \\"Accessible.PluralComponent.ACCESSIBILITY.HINT.\\\\(quantityType.rawValue)\\",
accessibilityLabelKey: \\"Accessible.PluralComponent.ACCESSIBILITY.LABEL.\\\\(quantityType.rawValue)\\",
accessibilityValueKey: \\"Accessible.PluralComponent.ACCESSIBILITY.VALUE.\\\\(quantityType.rawValue)\\",
translationKey: \\"Accessible.PluralComponent.COPY.\\\\(quantityType.rawValue)\\",
translationArgs: []
)
}
}
}",
"path": ".//ios/Localizable.swift",
Expand Down Expand Up @@ -1218,14 +1118,6 @@ struct L {
translationKey: \\"Something.With.An.Arbitrary.Amount.Of.Nesting.COPY\\",
translationArgs: []
)
static let Nesting = LocaliciousData(
accessibilityIdentifier: \\"Something.With.An.Arbitrary.Amount.Of.Nesting\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Something.With.An.Arbitrary.Amount.Of.Nesting.COPY\\",
translationArgs: []
)
}
}
}
Expand All @@ -1244,27 +1136,6 @@ struct L {
translationArgs: args
)
}
static func Title(args: CVarArg...) -> LocaliciousData {
return LocaliciousData(
accessibilityIdentifier: \\"Delivery.Widget.Title\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Delivery.Widget.Title.COPY\\",
translationArgs: args
)
}
static func SubTitle(quantity: Int, args: CVarArg...) -> LocaliciousData {
let quantityType = LocaliciousQuantity(quanitity: quantity)
return LocaliciousData(
accessibilityIdentifier: \\"Delivery.Widget.SubTitle\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Delivery.Widget.SubTitle.COPY.\\\\(quantityType.rawValue)\\",
translationArgs: args
)
}
static func SubTitle(quantity: Int, args: CVarArg...) -> LocaliciousData {
let quantityType = LocaliciousQuantity(quanitity: quantity)
return LocaliciousData(
Expand All @@ -1284,22 +1155,6 @@ struct L {
translationKey: \\"Delivery.Widget.SpecialCharacters.COPY\\",
translationArgs: []
)
static let SpecialCharacters = LocaliciousData(
accessibilityIdentifier: \\"Delivery.Widget.SpecialCharacters\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Delivery.Widget.SpecialCharacters.COPY\\",
translationArgs: []
)
static let MultilineStrings = LocaliciousData(
accessibilityIdentifier: \\"Delivery.Widget.MultilineStrings\\",
accessibilityHintKey: nil,
accessibilityLabelKey: nil,
accessibilityValueKey: nil,
translationKey: \\"Delivery.Widget.MultilineStrings.COPY\\",
translationArgs: []
)
static let MultilineStrings = LocaliciousData(
accessibilityIdentifier: \\"Delivery.Widget.MultilineStrings\\",
accessibilityHintKey: nil,
Expand All @@ -1319,25 +1174,6 @@ struct L {
translationKey: \\"Accessible.RegularComponent.COPY\\",
translationArgs: []
)
static let RegularComponent = LocaliciousData(
accessibilityIdentifier: \\"Accessible.RegularComponent\\",
accessibilityHintKey: \\"Accessible.RegularComponent.ACCESSIBILITY.HINT\\",
accessibilityLabelKey: \\"Accessible.RegularComponent.ACCESSIBILITY.LABEL\\",
accessibilityValueKey: nil,
translationKey: \\"Accessible.RegularComponent.COPY\\",
translationArgs: []
)
static func PluralComponent(quantity: Int) -> LocaliciousData {
let quantityType = LocaliciousQuantity(quanitity: quantity)
return LocaliciousData(
accessibilityIdentifier: \\"Accessible.PluralComponent\\",
accessibilityHintKey: \\"Accessible.PluralComponent.ACCESSIBILITY.HINT.\\\\(quantityType.rawValue)\\",
accessibilityLabelKey: \\"Accessible.PluralComponent.ACCESSIBILITY.LABEL.\\\\(quantityType.rawValue)\\",
accessibilityValueKey: \\"Accessible.PluralComponent.ACCESSIBILITY.VALUE.\\\\(quantityType.rawValue)\\",
translationKey: \\"Accessible.PluralComponent.COPY.\\\\(quantityType.rawValue)\\",
translationArgs: []
)
}
static func PluralComponent(quantity: Int) -> LocaliciousData {
let quantityType = LocaliciousQuantity(quanitity: quantity)
return LocaliciousData(
Expand Down

0 comments on commit 7703c23

Please sign in to comment.