Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentage encoding on Android #30

Closed
asvitzer opened this issue Apr 15, 2020 · 1 comment · Fixed by #32
Closed

Percentage encoding on Android #30

asvitzer opened this issue Apr 15, 2020 · 1 comment · Fixed by #32

Comments

@asvitzer
Copy link

Hello,

Can percentages be added to the encoding substitution for the Android platform?

Android Studio throws an error for strings that have a percentage in them but aren't format strings. An example:

<string name="over_achiever">"Na het behalen van 100%"</string>

If the % in the above string could become &#37; in the final strings XML file, that should fix the issue. And an exception should be added to not encode the percentage if it is included as part of a format string, as in See all in %1{{s}}

@larslockefeer
Copy link
Member

Hey @asvitzer, thanks for the report. It should be fixed by the PR I just submitted, could you double-check for me? Then I'll merge and cut a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants