Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search #4

Merged
merged 8 commits into from
Jan 16, 2023
Merged

Improve search #4

merged 8 commits into from
Jan 16, 2023

Conversation

mririgoyen
Copy link
Member

@mririgoyen mririgoyen commented Jan 15, 2023

This PR aims to improve and expand search functionality on the site. The more notable features added are:

  • Removes the IndexedDb solution.
    • IndexedDb doesn't do fuzzy searching without putting an entire table into memory.
    • If the entire dataset needs to be in memory, IndexedDb loses its usefulness since we can cache the datasets just as easily.
  • Created a DataProvider which does an initial data pull and places necessary data into memory. The data can then be retrieved by using a useData hook.
  • Implemented fuzzy searching on the Icon Library views.

More work to be done around search will come in another PR. This will include a full-site search, including search across all libraries and documentation.

@mririgoyen mririgoyen self-assigned this Jan 15, 2023
@mririgoyen mririgoyen mentioned this pull request Jan 15, 2023
@mririgoyen mririgoyen marked this pull request as ready for review January 16, 2023 18:55
@mririgoyen mririgoyen merged commit 0d54ff3 into main Jan 16, 2023
@mririgoyen mririgoyen deleted the improve-search branch January 18, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant