Full mitigation where refresh() is called many times using one Queue #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing, node-exit.ts call setNodeLocation with undefined variables. I added a queue to prevent this bug and for prevent visual glitches where refresh is called repeatedly. It can be tested in demo with "dev" script.
PierreCapo
approved these changes
May 3, 2020
|
Awesome @Pronink !! Thanks a lot for your help ❤️ Merging and doing a release right now |
|
A pleasure to have been able to help 😊😊😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for fix this issue #36
Where one refresh() is executed while another refresh() is transitioning, node-exit.ts call setNodeLocation with undefined variables.
I added a queue to prevent this bug and for prevent visual glitches where refresh is called repeatedly. It can be tested in demo with "dev" script. You can view queue in console changing
private static showQueueLog: boolean = falsetotruein utils.tsNow all refresh() calls are queued and they are executed one after the other, waiting transitions.
I think this is it a good solution. Ask me if what you need something or you think another way.
Big regards !!!