Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Clickable Link #52

Closed
KonradHoeffner opened this issue Mar 1, 2022 · 2 comments
Closed

Feature Request: Clickable Link #52

KonradHoeffner opened this issue Mar 1, 2022 · 2 comments

Comments

@KonradHoeffner
Copy link
Contributor

When I run the container, I get a message like...

9:52AM INF Listening at 0.0.0.0:8043 /...

...in gnome-terminal, however I cannot open the link 0.0.0.0:8043 in a browser when I click on it, even when I hold CTRL.

However when I use python -m http.server I get the message:

Serving HTTP on 0.0.0.0 port 8000 (http://0.0.0.0:8000/) ...

When I hover over http://0.0.0.0:8000/, the link gets underlined and I can open it with CTRL+click.

Maybe that is something done by GNOME terminal because the link starts with http, but it would be great if goStatic could adopt the same format as python -m http.server as I prefer it for three reasons:

  1. It does not have the time in front, which I don't need
  2. It does not have "INF" in it, which I don't need
  3. It contains the clickable HTTP link
@PierreZ
Copy link
Owner

PierreZ commented Mar 1, 2022

Hi 👋

Thanks for the feature request!

The time and the level (INF) are part of the logs, which are coming handy in production.

I think we just need to add "http://" here:

log.Info().Msgf("Listening at 0.0.0.0%v %v...", port, pathPrefix)

Do you want to open a PR for this?

@KonradHoeffner
Copy link
Contributor Author

Sure! Opened a pull request at #53.

@PierreZ PierreZ closed this as completed in d82050d Mar 3, 2022
PierreZ added a commit that referenced this issue Mar 3, 2022
Create clickable link. Resolve #52.
phred pushed a commit to phred/smolboi that referenced this issue Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants