Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC library simplification #6

Closed
wants to merge 6 commits into from
Closed

PoC library simplification #6

wants to merge 6 commits into from

Commits on Aug 9, 2022

  1. PoC library simplification

    Here is an aggressive PoC rewrite to simplify the library,
    while retaining most of the functionality.
    
    Some specific points:
    
    - Remove the special `MasterStatus` class.  This design was awkward,
      because it was a subclass of Status, but provided functionality
      that should have been provided by the StatusPool,
      resulting in a lot of edge case code.
      - Merge required functionality into the StatusPool.
    - Remove unnecessary classes; the clobberer classes could be pure functions.
    - Rename clobberer to summarizer
    - Leverage more existing code:
      - use UnknownStatus as-is
      - use StatusBase.from_name
    - Remove some magic, but retain just enough
      to still support `pool.status_name` get/set access shortcuts.
    - Remove the static subclass based approach to defining the pool
      (it's cool, but feels too magical, and I think in practice
      the procedural method of building the pool will be more practical).
    - Consolidate status tag and attr into a single name.
    - Remove the externally managed private variables from Status class.
    - Remove static class variables from Status class (originally for tracking ids for ordering)
    Samuel Walladge committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    a58dc93 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. add pyproject so can install with pip

    Samuel Walladge committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    905299f View commit details
    Browse the repository at this point in the history
  2. minor api change

    Samuel Walladge committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    34fb847 View commit details
    Browse the repository at this point in the history
  3. more api updates

    Samuel Walladge committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    dabdfe3 View commit details
    Browse the repository at this point in the history
  4. remove unused method

    Samuel Walladge committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    f2c99e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. ensure never set unknown status

    Samuel Walladge committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    406c68f View commit details
    Browse the repository at this point in the history