Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register click and touch event separately #389

Merged
merged 2 commits into from
Aug 24, 2015
Merged

Register click and touch event separately #389

merged 2 commits into from
Aug 24, 2015

Conversation

szwacz
Copy link
Contributor

@szwacz szwacz commented Aug 21, 2015

Fix for #374
Credit goes to @kaib84 but I'm doing the PR because of lack of response from that gentleman.

@nathancahill
Copy link
Contributor

Beyond that, it fixes #276, #301, #303, #324, #366 and #386. @rikkert, this should be merged and all of those can be closed.

@rikkert
Copy link
Member

rikkert commented Aug 22, 2015

Ok, this makes sense. But didn't we have this before and it still gave issues?
Also doesn't this result in _onMouseDown running twice because touch devices still handle mousedown?

@nathancahill
Copy link
Contributor

As I understand it (and from my limited testing on my devices) even when both listeners, only one or the other fires on click/tap. It looks like @kaib84 did more testing in #374

@szwacz
Copy link
Contributor Author

szwacz commented Aug 23, 2015

Indeed the event fires twice! But followed advice from this: http://www.html5rocks.com/en/mobile/touchandmouse/ and it isn't any more.

@nathancahill
Copy link
Contributor

👍 thanks @szwacz

@rikkert rikkert merged commit dabca3f into Pikaday:master Aug 24, 2015
rikkert added a commit that referenced this pull request Aug 24, 2015
@duizendnegen
Copy link

awesome, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants