Optimize touch events #397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
force-pushed
the
touch-optimize
branch
from
bbcd69b
to
e81114f
Compare
|
I can confirm that this patch is working great for me. Makes Pikaday usable on touch devices and, as far as I can tell, doesn't break anything. |
added 4 commits
May 30, 2016 11:59
We don't want the select to happen when users are scrolling the page.
On some touch devices, 'mousedown' event will fire when your are still holding your fingers. In Window Phone IE and Android 4.x, this causes select to happen when users are scrolling the page, which is annoying.
10px is big enough to trigger the scroll of an element. We certainly don't want to event to fire when the page/div has already scrolled.
This was referenced Nov 2, 2018
|
Any chance this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want the select to happen when users are scrolling the page.