Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option make keyboard support configurable, fixes #607 #610

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

IngoAlbers
Copy link
Contributor

No description provided.

Copy link

@pierred69 pierred69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to merge it now ?

@johman10
Copy link

johman10 commented Jan 26, 2017

@pierred69: I would love to get this merged to. In the meantime I found a custom solution which works for us in another project.

var picker = new Pikaday();
document.removeEventListener('keydown', picker._onKeyChange);

This kind of just removes the eventListener from the DOM and solves the problem.

@alpha-and-omega
Copy link

alpha-and-omega commented Apr 8, 2017

@johman10 Do you have any Idea how to use the "document.removeEventListener" hack in jQuery Pikaday plugin ?

@johman10
Copy link

johman10 commented Apr 8, 2017

@alpha-and-omega in theory the method I described should work. jQuery is just an extension of JS. Just try the code and see if it works. Else, maybe look into: http://api.jquery.com/off. That might be what you need.

@kaldras
Copy link

kaldras commented Apr 19, 2017

Any update on when this will be merged? We need a option like this and would prefer not to make a custom hack for the plugin.

@rikkert rikkert merged commit 82c966c into Pikaday:master Jun 14, 2017
@ajhsu
Copy link

ajhsu commented Nov 27, 2017

Since the option has been merged in June 2017; When will 1.7.0 be released on npm, so that we can take the advantage of this option?

@IngoAlbers IngoAlbers deleted the iss_607 branch November 27, 2017 10:49
@rikkert
Copy link
Member

rikkert commented Nov 27, 2017 via email

@ajhsu
Copy link

ajhsu commented Nov 27, 2017

@rikkert It's good to know that! Thanks in advance 👍

akash1810 added a commit to guardian/grid that referenced this pull request Jul 9, 2018
Pikaday is hijacking keyboard navigation, resulting in cursor navigation failing (its impossible to go left!).

Remove the event listeners from pikaday, see Pikaday/Pikaday#610 and Pikaday/Pikaday#607.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants