-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option make keyboard support configurable, fixes #607 #610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to merge it now ?
@pierred69: I would love to get this merged to. In the meantime I found a custom solution which works for us in another project. var picker = new Pikaday();
document.removeEventListener('keydown', picker._onKeyChange); This kind of just removes the eventListener from the DOM and solves the problem. |
@johman10 Do you have any Idea how to use the "document.removeEventListener" hack in jQuery Pikaday plugin ? |
@alpha-and-omega in theory the method I described should work. jQuery is just an extension of JS. Just try the code and see if it works. Else, maybe look into: http://api.jquery.com/off. That might be what you need. |
Any update on when this will be merged? We need a option like this and would prefer not to make a custom hack for the plugin. |
Since the option has been merged in June 2017; When will 1.7.0 be released on npm, so that we can take the advantage of this option? |
Will do asap thanks for the reminder
…On Mon, 27 Nov 2017 at 11:47, AJ Hsu ***@***.***> wrote:
Since this option has been merged in June 2017; When will 1.7.0 be
released on npm, so that we can take the advantage of this option?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#610 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAJZJtiQ-svfBhtN9Gs81V_yjYDRwDpMks5s6pNYgaJpZM4Kuggs>
.
|
@rikkert It's good to know that! Thanks in advance 👍 |
Pikaday is hijacking keyboard navigation, resulting in cursor navigation failing (its impossible to go left!). Remove the event listeners from pikaday, see Pikaday/Pikaday#610 and Pikaday/Pikaday#607.
No description provided.