Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS-classes indicating position #747

Merged
merged 2 commits into from Dec 19, 2017

Conversation

rubenswieringa
Copy link
Contributor

@rubenswieringa rubenswieringa commented Dec 7, 2017

This feature allows for the styling of the datepicker to change according to where it is relative to field – for example datepickers that are styled to have a pointer that points to a date-input.

CSS-classnames (open to suggestions):

  • top-aligned
  • bottom-aligned
  • left-aligned
  • right-aligned

I had some trouble getting your tests and linting to work. If you want me to do something for that then could you give me some pointers on how to get that up and running?

@rikkert
Copy link
Member

rikkert commented Dec 12, 2017

If you can also add to the readme and add an example I'm happy to merge.
Running: npm run lint should warn you about linting errors.

@rubenswieringa rubenswieringa force-pushed the reposition-css-classes branch 3 times, most recently from fb1d796 to e2224b0 Compare December 12, 2017 13:53
@rubenswieringa
Copy link
Contributor Author

The CSS-classes are now mentioned in the readme and here's an example: https://plnkr.co/edit/IS6gpzw0dg1hUZzXYHk8?p=preview

…I take it you meant a working example, rather than a code-example in the documentation?

Thanks :)

@rikkert
Copy link
Member

rikkert commented Dec 12, 2017

That is great thanks, I meant in the example folder of this repo.

@rubenswieringa
Copy link
Contributor Author

I meant in the example folder of this repo.

Lol, I'll get on it tomorrow and will hit you up.

@rubenswieringa
Copy link
Contributor Author

@rikkert Should be good now, let me know if there's anything I can improve!

@rikkert rikkert merged commit eddaaa3 into Pikaday:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants