Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make another volume with exercises [.noedit & Last-modified through api] #31

Closed
Nircek opened this issue Mar 17, 2021 · 7 comments
Closed
Assignees

Comments

@Nircek
Copy link
Member

Nircek commented Mar 17, 2021

What do you think about running a script that fetches new updates from the Pikne-Programy/pikne-zadania-exercises repo?
Currently, we need to update the submodule, commit it, and wait for a build. That would be troublesome in the future.

@Nircek Nircek self-assigned this Mar 17, 2021
@Nircek
Copy link
Member Author

Nircek commented Mar 17, 2021

We can use this: https://github.com/opsxcq/tasker

@Nircek Nircek mentioned this issue Mar 28, 2021
@Nircek
Copy link
Member Author

Nircek commented Mar 28, 2021

Or maybe, it will be better to make the volume with exercises and optionally update it with the other container?

@Nircek
Copy link
Member Author

Nircek commented Jun 3, 2021

I think the automatic updates are not possible in case we want to give users a possibility to change existing exercises. It would be just too complicated process and should be made manually (it will not be just git pull).

@Nircek Nircek changed the title Update exercises database without build Make another volume with exercises Jun 3, 2021
@Nircek
Copy link
Member Author

Nircek commented Jun 3, 2021

It would be nice to have a possibility to lock the exercise volume during an update. Creating a file .noedit will prevent the server from changing files.

@Nircek Nircek added this to the v0.3 - the realtime prototype milestone Jun 3, 2021
@Nircek
Copy link
Member Author

Nircek commented Jul 2, 2021

The volume works. I added it in f0a4a56. I keep the issue open to remind me of .noedit file.

@Nircek
Copy link
Member Author

Nircek commented Aug 8, 2021

When an admin creates a .noedit file, we can expect they made some changes on the disk, so it would be nice to reload the exercises (if we don't sync it with disk events #41).

Nevertheless, a user can make a change simultaneously. I assume we should store a timestamp of the last fetch from the database and then, the server can compare it with the stored one. When the requested change has an older timestamp, it indicates the server should abort that request because it would overwrite the admin's changes.







@miloszwasacz, what do you think about this that? Feel free to edit the API docs when you figure something out.

@Nircek Nircek changed the title Make another volume with exercises Make another volume with exercises [.noedit & Last-modified through api] Aug 9, 2021
@Nircek
Copy link
Member Author

Nircek commented Oct 30, 2021

Okay, the primary issue is resolved and IMO the .noedit and Last-modified would be good only in case of getting #41 true. Closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant