Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up comments #21

Merged
merged 6 commits into from
Feb 23, 2017
Merged

Conversation

tiwanari
Copy link
Member

Solves #16. This PR does the same things on PileProject/drive#62. While some methods haven't had enough explanation yet, it follows the style of general JavaDocs.

@tiwanari
Copy link
Member Author

ping @Myusak @amiq11

Here, I've made a PR which is similar to PileProject/drive#62

Please feel free to leave comments:)

Copy link
Member

@mandaiy mandaiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that you might need to replace "The Drivecommand Authors" according to the discussion in PileProject/drive#62 .
Or you can do it in another pull request.

@tiwanari
Copy link
Member Author

@Myusak Thank you for your review and reminder! I will fix the author notice in this PR:) Please give me a little time.

@tiwanari tiwanari merged commit 37a4b6f into PileProject:develop Feb 23, 2017
@tiwanari tiwanari deleted the hotfix/clean_up_comments branch February 23, 2017 12:58
This was referenced Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants