nextcloud: migration: add nextcloud config maintenance_window_start

Fix nextcloud-snap#2658

src/nextcloud/config/config.php

@@ -55,4 +55,5 @@
 'log_type' => 'file',
 'logfile' => $snap_data_current.'/logs/nextcloud.log',
 'logfilemode' => 0640,
+'maintenance_window_start' => 1,
 );

src/nextcloud/fixes/existing-install/7_add_maintenance_window.sh

@@ -0,0 +1,7 @@
+#!/bin/sh -e
+
+# Check if config 'maintenance_window_start' doesn't exist or has no value set
+if ! occ -n config:system:get maintenance_window_start; then
+	# Set default 'maintenance_window_start' to 1 a.m. (UTC)
+	occ -n config:system:set maintenance_window_start --value=1 --type=integer
+fi

tests/unit/migrations/add_maintenance_window_start_spec.sh

@@ -0,0 +1,50 @@
+Describe 'add-maintenance-window-start migration'
+	BeforeEach 'setup'
+	AfterEach 'teardown'
+	setup()
+	{
+		SPEC_TMPDIR="$(mktemp --directory --tmpdir nextcloud-snap-tests.XXXXXXXXXX)"
+		MIGRATION="src/migrations/migrations/28.0.0snap1/1_add-maintenance-window-start.sh"
+
+		# Create nextcloud config for the migration to tweak
+		mkdir -p "$SPEC_TMPDIR/nextcloud/config"
+		CONFIG_FILE="$SPEC_TMPDIR/nextcloud/config/config.php"
+		touch "$CONFIG_FILE"
+
+		# Make the migration look in the right place
+		export SNAP_DATA="$SPEC_TMPDIR"
+	}
+
+	teardown()
+	{
+		rm -rf "$SPEC_TMPDIR"
+	}
+
+	It 'handles empty config file'
+		When call "$MIGRATION"
+		The status should be failure
+	End
+
+	It 'handles basic config file'
+		cat <<- "EOF" > "$CONFIG_FILE"
+			?php
+
+			$CONFIG = array(
+			);
+		EOF
+
+		expected_content=$(cat <<- "EOF"
+			?php
+
+			$CONFIG = array(
+			'maintenance_window_start' => 1,
+			);
+		EOF
+		)
+
+		When call "$MIGRATION"
+		The status should be success
+		The output should include "The config ''maintenance_window_start' => 1,' has been added"
+		The contents of file "$CONFIG_FILE" should equal "$expected_content"
+	End
+End

tests/unit/spec_helper.sh

@@ -12,7 +12,7 @@ spec_helper_precheck()
   # Available variables: VERSION, SHELL_TYPE, SHELL_VERSION
   : minimum_version "0.28.1"
   setenv SNAP="$SHELLSPEC_PROJECT_ROOT/src/common"
-  setenv NEXTCLOUD_SCRIPT_INCLUDE_PATH="src/common/utilities:src/apache/utilities:src/https/utilities:src/php/utilities:src/hooks/utilities"
+  setenv NEXTCLOUD_SCRIPT_INCLUDE_PATH="src/common/utilities:src/apache/utilities:src/https/utilities:src/php/utilities:src/hooks/utilities:src/nextcloud/utilities"
 }
 
 # This callback function will be invoked after a specfile has been loaded.