Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve buildability by using Docker #59

Merged
merged 15 commits into from
Jun 22, 2022

Conversation

jcobol
Copy link

@jcobol jcobol commented Jun 18, 2022

Needs discussion and testing, but this is an option to ease building the v2/asm/ contents.

Known issue: C64LIST4BETAA and C64LIST4BETAC both point to a path inside the Docker container and use the same compiler version. Building outside the Docker container should still be supported, so needs a tweak. Regarding compiler version, I don't know if use C64List4.04 will produce the expected output (needs testing) but it does pass the build.

The Dockerfile could use some optimization to make the image smaller.

@jcobol jcobol mentioned this pull request Jun 18, 2022
@Pinacolada64
Copy link
Owner

Pinacolada64 commented Jun 20, 2022

Hi. Thanks for contributing. I'm not really familiar with Docker, I tried to read about it once or twice and still came away confused. I'll go back and try to understand, a lot of people are mentioning it nowadays.

Since these makefiles were written, c64list 4.04 can handle assembling .asm (assembly) files, .bin (no load address binary files) and .lbl (BASIC) files, so the BETAA and BETAC executables aren't needed anymore. I'll ask Jeff if we could include a link to his Google Drive download of c64list4.04 in the revised README.

v2/asm/irqhn.asm Outdated Show resolved Hide resolved
Copy link
Owner

@Pinacolada64 Pinacolada64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have a .pdf instead of a .docx file. I uploaded one to master/v2/docker/files/C64List4.04/ so it'll match your path when the pull request gets merged.

Pinacolada64 added a commit that referenced this pull request Jun 21, 2022
- Will match path of PR #59 when it gets merged
@jcobol
Copy link
Author

jcobol commented Jun 22, 2022

I'd like to have a .pdf instead of a .docx file. I uploaded one to master/v2/docker/files/C64List4.04/ so it'll match your path when the pull request gets merged.

Ok - I've removed the .docx file from my PR so we'll just be left with the .pdf.

I don't see any use of the "comma" label, so it can be repurposed to stand in for Pinacolada64#44/$2c/','
Made "printable characters" its own section so as not to confuse it with a zero-page address. :)
@Pinacolada64 Pinacolada64 merged commit 115201c into Pinacolada64:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants