Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

💬 Make gitmoji mandatory #289

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

Enderchief
Copy link
Member

Changes

  • improvements: gitmoji is now mandatory

We use it anyways for all commits (or at least we should). The prs that do not have it are squashed to have them.

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #289 (057c929) into main (3490461) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files           9        9           
  Lines         100      100           
=======================================
  Hits           90       90           
  Misses         10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3490461...057c929. Read the comment docs.

@Lunarmagpie
Copy link
Member

This is the best pr in the entire project

Copy link
Member

@Arthurdw Arthurdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was very difficult to review, lots of changes, will be merged
Thanks for your contribution <3

@Arthurdw Arthurdw merged commit 40c66ff into Pincer-org:main Dec 3, 2021
@VincentRPS
Copy link
Contributor

should've also allowed other commit styles like conventional commits or semantic commits they are still readable for people looking at them,
there is also the udacity & nist style guides which would still be readable, it would also be great not to be just stuck to one commit style.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants