This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
✨ Added sticker support #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 9 9
Lines 100 100
=======================================
Hits 90 90
Misses 10 10 Continue to review full report at Codecov.
|
Sigmanificient
suggested changes
Dec 5, 2021
trag1c
suggested changes
Dec 5, 2021
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com> 🎨 Improving formatting Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com> 🎨 Improving formatting Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com> 🎨 Improving formatting Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com> 🎨 Improving formatting Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Sigmanificient
force-pushed
the
stickers
branch
from
afc8b90
to
219cf5c
Compare
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
|
bruh github mobile app dog UX |
Lunarmagpie
suggested changes
Dec 7, 2021
Co-authored-by: Lunarmagpie <65521138+Lunarmagpie@users.noreply.github.com>
trag1c
suggested changes
Dec 7, 2021
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Sigmanificient
suggested changes
Dec 7, 2021
| return Role.from_dict( | ||
| construct_client_dict( | ||
| self._client, | ||
| await self._http.post( | ||
| f"guilds/{self.id}/roles", | ||
| data=kwargs, | ||
| headers=remove_none({"X-Audit-Log-Reason": reason}) | ||
| headers=remove_none({"X-Audit-Log-Reason": reason}), |
There was a problem hiding this comment.
no comma, I dont think we should listen to black for this one rule
There was a problem hiding this comment.
@Sigmanificient If so, find a way to remove trailing commas from black. We cannot always have to remove the commas whenever we format. It would be tedious especially as the project grows.
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Lunarmagpie
approved these changes
Dec 9, 2021
trag1c
approved these changes
Dec 9, 2021
Sigmanificient
suggested changes
Dec 9, 2021
oops. i forgor 💀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
adds: Add functions for stickers#265
Check off the following