This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
✨ Rewrote command registration and added cogs #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentRPS
reviewed
Jan 16, 2022
Sigmanificient
suggested changes
Jan 16, 2022
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #389 +/- ##
=======================================
Coverage 91.17% 91.17%
=======================================
Files 9 9
Lines 102 102
=======================================
Hits 93 93
Misses 9 9 Continue to review full report at Codecov.
|
|
Time to be reviewed again 💀 |
Sigmanificient
approved these changes
Jan 19, 2022
Enderchief
suggested changes
Jan 20, 2022
Co-authored-by: Endercheif <45527309+Endercheif@users.noreply.github.com>
Co-authored-by: Endercheif <45527309+Endercheif@users.noreply.github.com>
trag1c
suggested changes
Jan 26, 2022
Comment on lines
+104
to
+110
| return list( | ||
| map( | ||
| AppCommand.from_dict, | ||
| await self.client.http.get(self.__prefix + self.__get) | ||
| + [cmd for guild in guild_commands for cmd in guild], | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Suggested change
| return list( | |
| map( | |
| AppCommand.from_dict, | |
| await self.client.http.get(self.__prefix + self.__get) | |
| + [cmd for guild in guild_commands for cmd in guild], | |
| ) | |
| ) | |
| return [*map( | |
| AppCommand.from_dict, | |
| await self.client.http.get(self.__prefix + self.__get) | |
| + [cmd for guild in guild_commands for cmd in guild], | |
| )] |
pincer/client.py
Outdated
Comment on lines
339
to
341
| event = InteractableStructure( | ||
| call=coroutine | ||
| ) |
There was a problem hiding this comment.
Suggested change
| event = InteractableStructure( | |
| call=coroutine | |
| ) | |
| event = InteractableStructure(call=coroutine) |
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Co-authored-by: trag1c <77130613+trag1c@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
adds: Cogs. Look at the cog example to see how it works. Also kills old cog system.fixed: Commands and Message Components are registered when a class is initiated. This makes pincer a lot more modular and any class can register a cog now. as long as it inherits fromInteractableFUNCTIONAL BOTS WILL BE IMPOSSIBLE IF THIS GETS MERGED.Rewrote and they're possible + betterimprovements: ...Check off the following