Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pingcap/tidb): bump go version to v1.21.0 #2341

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

hawkingrei
Copy link
Contributor

@hawkingrei hawkingrei commented Aug 9, 2023

Go v1.21.0 was release, we need to upgrade the CI/CD container image to adjust for pingcap/tidb repo.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:

This pull request upgrades the Go version from 1.20 to 1.21. It updates the image for various containers and pods with the new version.

Potential Problems:

It's hard to find potential problems in this pull request because it's a simple upgrade. However, it's important to check if any of the dependencies or the codebase is incompatible with the new version of Go.

Fixing Suggestions:

The author has already updated the images and containers in the codebase. However, it's recommended to test the application thoroughly to make sure everything is working as expected with the new version of Go.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
This pull request upgrades the Go version from 1.20 to 1.21 in various files, replacing the previous image tags with new ones. The changes seem straightforward and there are no potential problems that stand out.

One suggestion for improvement would be to add a description to the pull request, explaining the reason for the upgrade and any benefits it may provide.

@wuhuizuo wuhuizuo changed the title *: upgrade go1.21 *: bump go version to v1.21.0 Aug 9, 2023
@wuhuizuo wuhuizuo changed the title *: bump go version to v1.21.0 chore(pingcap/tidb): bump go version to v1.21.0 Aug 9, 2023
@wuhuizuo
Copy link
Collaborator

wuhuizuo commented Aug 9, 2023

/lgtm
/approve

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 9, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-09 02:11:56.679671736 +0000 UTC m=+78681.228687720: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 9, 2023
@ti-chi-bot ti-chi-bot bot merged commit 94bab50 into PingCAP-QE:main Aug 9, 2023
2 checks passed
@shawn0915 shawn0915 mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants