Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase ticdc pulsar integration test resource #2932

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

sdojjy
Copy link
Contributor

@sdojjy sdojjy commented Apr 22, 2024

ticdc pulsar integration test failed frequently, but when we run it on local env, it never fail, so this PR increase ticdc pulsar integration test resource.

Copy link

ti-chi-bot bot commented Apr 22, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

The pull request is about increasing the resources for the tikdc pulsar integration test which is failing frequently. The change involves increasing the memory and CPU limits from 16Gi and 8 CPU to 32Gi and 16 CPU respectively.

There are no potential problems with this change, except that it could be expensive to run a test with such high resources. However, since the test is failing frequently, increasing the resources may help to stabilize it.

As a suggestion, it would be good to investigate why the test is failing frequently and try to fix the root cause of the issue. Also, it would be good to monitor the resource usage during the test to ensure that it doesn't exceed the available resources.

Overall, the change seems reasonable, and it is a good short-term solution to stabilize the test.

@ti-chi-bot ti-chi-bot bot removed the lgtm label Apr 22, 2024
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

ti-chi-bot bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 22, 2024
Copy link

ti-chi-bot bot commented Apr 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-22 06:33:01.332437916 +0000 UTC m=+838200.443484366: ☑️ agreed by asddongmen.
  • 2024-04-22 06:37:27.68878408 +0000 UTC m=+838466.799830529: ✖️🔁 reset by sdojjy.
  • 2024-04-22 06:38:01.599878992 +0000 UTC m=+838500.710925453: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot merged commit 886fe0b into PingCAP-QE:main Apr 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants