-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase ticdc pulsar integration test resource #2932
increase ticdc pulsar integration test resource #2932
Conversation
The pull request is about increasing the resources for the tikdc pulsar integration test which is failing frequently. The change involves increasing the memory and CPU limits from 16Gi and 8 CPU to 32Gi and 16 CPU respectively. There are no potential problems with this change, except that it could be expensive to run a test with such high resources. However, since the test is failing frequently, increasing the resources may help to stabilize it. As a suggestion, it would be good to investigate why the test is failing frequently and try to fix the root cause of the issue. Also, it would be good to monitor the resource usage during the test to ensure that it doesn't exceed the available resources. Overall, the change seems reasonable, and it is a good short-term solution to stabilize the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, purelind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
ticdc pulsar integration test failed frequently, but when we run it on local env, it never fail, so this PR increase ticdc pulsar integration test resource.