-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tidb): test flashbacktest package #2942
Conversation
Based on the pull request title and diff, it appears that the changes are adding a new test package called As for potential problems, it's hard to say without more information. However, adding a new test package could potentially increase the build time or cause issues with existing tests. It's important to ensure that the new tests are properly written and do not conflict with any existing tests. In terms of fixing suggestions, it would be helpful if the pull request description included more information about the new test package and why it is being added. Additionally, it would be a good idea to thoroughly test the new tests to make sure they are working correctly and do not cause any issues with existing tests. It may also be worth considering if there are any ways to optimize the pipeline to minimize any impact on build time. |
test passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: purelind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.