-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "refactor(jenkins/pipelines,pipelines): use the new dockerfile url location" #2959
Conversation
… url loc…" This reverts commit 1a8e788.
Based on the pull request title and description, it seems that the changes made in #2958 are being reverted. The diff shows that the Dockerfile URLs are being changed from the new location to the old one. Potential problems with this pull request could be:
Some suggestions to fix these problems could be:
|
/review default |
It seems this pull request is reverting a previous change that broke the dev-builds due to a problem with the Docker build command. The change that is being reverted is a refactor of the Jenkins pipelines that changed the location of the Dockerfile URLs. There are no potential problems with the code changes since the pull request is just reverting a previous change. However, there might be issues with the dev builds if the previous problem is not resolved. My suggestion is to investigate the issue with the Docker build command and fix it before attempting to refactor the Jenkins pipelines. Once the issue is fixed, the previous refactor can be revisited and implemented again. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reverts #2958
It broken the dev-builds since of the issue, we must solve it atomic: