Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add basic auth to allow target #55

Merged
merged 14 commits into from
Dec 13, 2023
Merged

feat: add basic auth to allow target #55

merged 14 commits into from
Dec 13, 2023

Conversation

lijie0123
Copy link
Contributor

@lijie0123 lijie0123 commented Dec 13, 2023 •
edited

Why:

  • some users want use devbuild for nighly, hoping to push to given target image address

How:

  • add basic auth, with shared token
  • allow given target image if he is admin
  • add a big account for front end and chat-bot
  • allow GitRef like: branch/feature/...

@lijie0123
feat: remove branch limitation
0dd16c1 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
feat: support target image path after authenticate
1607d58 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
test: add more test case
9a29651 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
feat: use new type for ctx
0825f82 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
feat: add confidential
b1bf599 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
fix: cmd arg
20d0378 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
doc: swagger
b64879b 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
fix: pass param to jenkins
1fef7da 
Signed-off-by: lijie <lijie@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the size/L label Dec 13, 2023
@lijie0123
fix: forbid target img and hotfix
79ad448 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
fix: test
e4529c9 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
refract: rename function
046682a 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
refract: just simply global var
a515e9d 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
refract: use pointer
007083b 
Signed-off-by: lijie <lijie@pingcap.com>
@wuhuizuo wuhuizuo mentioned this pull request Dec 13, 2023
Merged
@lijie0123
feat: rename api secret
1256f0b 
Signed-off-by: lijie <lijie@pingcap.com>
wuhuizuo
wuhuizuo approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

wait for manual test

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 13, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-13 10:07:56.352667564 +0000 UTC m=+437167.389894486: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 13, 2023
@lijie0123
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot merged commit d987e3c into main Dec 13, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the target_position branch December 13, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuhuizuo wuhuizuo wuhuizuo approved these changes

@purelind purelind Awaiting requested review from purelind

Assignees

@wuhuizuo wuhuizuo

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lijie0123 @wuhuizuo