Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dl): implement DL(downloader) server #56

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Conversation

wuhuizuo
Copy link
Contributor

practice with Goa design

It looks good.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link

ti-chi-bot bot commented Dec 14, 2023

I Skip it since the diff size(174545 bytes > 80000 bytes) is too large

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link

ti-chi-bot bot commented Dec 14, 2023

I Skip it since the diff size(178101 bytes > 80000 bytes) is too large

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link

ti-chi-bot bot commented Dec 14, 2023

I Skip it since the diff size(215643 bytes > 80000 bytes) is too large

go test is not stable for linux/arm64 platform, skip go test in docker building.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link

ti-chi-bot bot commented Dec 15, 2023

I Skip it since the diff size(216118 bytes > 80000 bytes) is too large

@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 15, 2023
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link

ti-chi-bot bot commented Dec 15, 2023

I Skip it since the diff size(217522 bytes > 80000 bytes) is too large

@ti-chi-bot ti-chi-bot bot merged commit 9cf4276 into main Dec 15, 2023
2 of 3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/new-fileserver branch December 15, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant