Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github require loggin to avoid rate limit #74

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

lijie0123
Copy link
Contributor

@lijie0123 lijie0123 commented Feb 22, 2024

Why:

  • GitHub API rate limit exceeded, need login to github in order to increase limit

How:

  • add token to github client
  • some refract for tbctl.py

Signed-off-by: lijie <lijie@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the size/M label Feb 22, 2024
Signed-off-by: lijie <lijie@pingcap.com>
Copy link

ti-chi-bot bot commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Feb 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-23 05:07:02.421268699 +0000 UTC m=+592911.168891810: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 23, 2024
@ti-chi-bot ti-chi-bot bot merged commit ee6ff74 into main Feb 23, 2024
2 of 3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/github_limit branch February 23, 2024 05:07
lijie0123 added a commit to PingCAP-QE/ee-ops that referenced this pull request Feb 23, 2024
ti-chi-bot bot pushed a commit to PingCAP-QE/ee-ops that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants