Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tekton artifact list #80

Merged
merged 11 commits into from
Feb 28, 2024
Merged

fix: tekton artifact list #80

merged 11 commits into from
Feb 28, 2024

Conversation

lijie0123
Copy link
Contributor

Why:

  • pipeline url typo (we can make it configurable later)
  • fix build report flash old artifacts while processing new event

How:

  • fix typo
  • avoid flash BuildReport.Images every time while processing each pipeline event

@lijie0123
fix: tekton pipeline url
e0352df 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
fix: merge tekton artifact list
be925a7 
Signed-off-by: lijie <lijie@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the size/S label Feb 27, 2024
@lijie0123
style: var name
a21c576 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
Copy link
Contributor Author

/hold

@lijie0123
feat: use config insteadof const
f16e914 
Signed-off-by: lijie <lijie@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels Feb 27, 2024
@lijie0123
refract: split function
9b73e9d 
Signed-off-by: lijie <lijie@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/L and removed size/M labels Feb 27, 2024
@lijie0123
style: eol
5d00c3c 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
feat: rename oras to oci
e8d670d 
Signed-off-by: lijie <lijie@pingcap.com>
wuhuizuo
wuhuizuo requested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need fix the nil pointer issue.

@lijie0123
fix: do not use pointer
4e37270 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
fix: remove unused comment
3fa4d40 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
fix: panic on parse error
f51bf48 
Signed-off-by: lijie <lijie@pingcap.com>
@lijie0123
fix: pinic
60d2dcc 
Signed-off-by: lijie <lijie@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 28, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-28 05:02:36.369278533 +0000 UTC m=+1024645.116901640: ✖️🔁 reset by wuhuizuo.
  • 2024-02-28 07:00:51.43637495 +0000 UTC m=+1031740.183998066: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 28, 2024
@lijie0123
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot merged commit 63b9f30 into main Feb 28, 2024
2 of 3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/tekton_artifact branch February 28, 2024 08:02
lijie0123 added a commit to PingCAP-QE/ee-ops that referenced this pull request Feb 28, 2024
@lijie0123
chore: update tibuild
a363976 
Why:
- ref PingCAP-QE/ee-apps#80
@lijie0123 lijie0123 mentioned this pull request Feb 28, 2024
Merged
ti-chi-bot bot pushed a commit to PingCAP-QE/ee-ops that referenced this pull request Feb 28, 2024
@lijie0123
chore: update tibuild (#1001)
f9d339e 
Why:
- ref PingCAP-QE/ee-apps#80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuhuizuo wuhuizuo wuhuizuo approved these changes

@purelind purelind Awaiting requested review from purelind

Assignees

@wuhuizuo wuhuizuo

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lijie0123 @wuhuizuo