[BUG] Integer prop with options does not accept 0 as a value #5429
Labels
bug
Something isn't working
tracked internally
Issue is also tracked in our internal issue tracker
triaged
For maintainers: This issue has been triaged by a Pipedream employee
Comments
GTFalcao
added a commit
that referenced
this issue
Feb 8, 2023
vunguyenhung
added
the
tracked internally
dylburger
added
the
triaged
GTFalcao
added a commit
that referenced
this issue
Feb 10, 2023
* "Formatter" app structure * pnpm lock * Creating date-time formats * Common date formatting for options * Output functions for date formats * Date Formatting action * using temporary app for testing * Adjusting time formatting option labels * Add/Subtract Time action * prop definitions for date input and formats * Reusing code for date-time actions * Base for number formatting actions * Adding currencies + ESLint fixes * "Format Number" action * "Format number" adjustments * "Transform Case" and adjustments * Action "Default value" for text * "Extract Email Address" action * Base for text extract actions + extract number * "Extract phone number" with predefined RegExps * Extract by URL and Regular Expression actions * Fixes on extract actions * "Trim Whitespace" action * "Split Text" action and util "buildRegExp" file * Split Text and RegExp adjustments * "Replace text" action with string and regex * URL Encode and Decode actions * HTML and Markdown conversion actions * Renaming files to keep camelCase naming * Creating 'compare dates' and utility date/time units * ESLint * Improvements * Adding packages for 'pluralize' and 'title-case' * RegExp fixes * Currency and number formatting * ESLint * Updated list of currencies and formatting * Number formatting adjustments * Error catching and syntax improvements for currency formatting * Adding 'formatting' app to actions * Adjustments * Changing 'formatter' folder to 'formatting' * pnpm lock * Adjusting value 0 as per issue #5429 * Updating package.json version * PR review changes * Adding app prop to actions missing it * Bug fix * Text Extraction actions description updates * Name and description updates * Adding output date format * ESLint fixes * Rename 'default-value' -> 'set-default-value' * Adding option to infer integer input for dates * Typo fixes * Creating JSON conversion actions * Converting input to string on number actions
|
Hey is this issue still open? I would like to work |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Integer props normally accept
0as a valid value, but that is not the case if the value comes from a user-selectedoption.To Reproduce
I've created a sample action at
components/formatting/actions/integer-option-zero-example/in a branch named bug-sample_integer-option-zero to easily reproduce this. Simply publish that action and enter/select values as shown on the screenshots below.Expected behavior
0 should be a valid value for option-based integer props, since it is valid for integer props without options.
Screenshots
Here's an integer prop without options, accepting 0 as a value:
And here's an integer prop with options, including one with 0 as a value, which it does not accept as valid:
The text was updated successfully, but these errors were encountered: