Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACTION] SFTP — Upload file via file reference (i.e. a file on /tmp) #7601

Closed
dylburger opened this issue Aug 16, 2023 · 1 comment · Fixed by #7608
Closed

[ACTION] SFTP — Upload file via file reference (i.e. a file on /tmp) #7601

dylburger opened this issue Aug 16, 2023 · 1 comment · Fixed by #7608
Assignees
@alysonturing
Labels
action New Action Request enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@dylburger
Copy link
Contributor

Is there a specific app this action is for?

We should probably just refactor this action:

  1. Ask the user whether they'd like to upload a file from /tmp or create a file from data (existing option).
  2. Add additionalProps to let the user enter a path / file data according to their choice in Adding Mediums feed of updates. #1.
@dylburger dylburger added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers action New Action Request labels Aug 16, 2023
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Aug 16, 2023
@alysonturing alysonturing self-assigned this Aug 16, 2023
@alysonturing alysonturing linked a pull request Aug 16, 2023 that will close this issue
sftp - improving upload file action #7608
Merged
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/ACTION-SFTP-Upload-file-via-file-reference-i-e-a-file-on-tmp-7601-24cfcb7832dd42a8b915cb700248dba9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alysonturing alysonturing

Labels
action New Action Request enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed triaged For maintainers: This issue has been triaged by a Pipedream employee
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sftp - improving upload file action PipedreamHQ/pipedream
3 participants
@dylburger @vunguyenhung @alysonturing