Zoho Survey - Update per feedback from their team #12457
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe recent updates to the Zoho Survey component include a version upgrade, handling of HTML entity decoding, improved response ID management, enhanced label processing using the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ZohoSurveyApp
participant HTMLEntitiesDecoder
User ->> ZohoSurveyApp: Requests new survey response
ZohoSurveyApp ->> HTMLEntitiesDecoder: Decode labels
HTMLEntitiesDecoder -->> ZohoSurveyApp: Decoded labels
ZohoSurveyApp -->> User: Returns decoded survey data
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (4)
- components/zoho_survey/actions/send-email-invitation/send-email-invitation.mjs (1 hunks)
- components/zoho_survey/package.json (2 hunks)
- components/zoho_survey/sources/new-survey-response/new-survey-response.mjs (4 hunks)
- components/zoho_survey/zoho_survey.app.mjs (6 hunks)
Files skipped from review due to trivial changes (2)
- components/zoho_survey/actions/send-email-invitation/send-email-invitation.mjs
- components/zoho_survey/package.json
Additional comments not posted (7)
components/zoho_survey/sources/new-survey-response/new-survey-response.mjs (5)
2-2: Added import ofhtml-entities-decoder.This is in line with the PR's objective to decode HTML entities in API responses.
10-10: Version updated from "0.0.2" to "0.0.3".This reflects the functional enhancements made in this update.
21-22: Updated the handling ofRESPONSE_IDfor consistency.Ensure that all references to
Response IDin your project are updated toRESPONSE_IDto maintain consistency.
32-32: Enhanced label processing by incorporating bothkeyandlabelincollectFieldLabels.This change supports the more robust handling of survey fields as outlined in the PR objectives.
47-72: Decoding HTML entities in labels and values to ensure proper display of characters.This change is crucial for correctly displaying characters that might otherwise be misinterpreted by HTML.
components/zoho_survey/zoho_survey.app.mjs (2)
2-2: Import added forhtml-entities-decoder.This supports the functionality to decode HTML entities across the application.
19-19: Decoded labels in various properties to handle HTML entities correctly.This ensures that all labels displayed in the UI are correctly processed to show meaningful characters instead of HTML codes.
Also applies to: 34-34, 60-60, 80-80, 104-104
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (1)
- components/zoho_survey/sources/new-survey-response/new-survey-response.mjs (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- components/zoho_survey/sources/new-survey-response/new-survey-response.mjs
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (1)
- components/zoho_survey/sources/new-survey-response/new-survey-response.mjs (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- components/zoho_survey/sources/new-survey-response/new-survey-response.mjs
|
/approve |
Resolves #12438
Summary by CodeRabbit
New Features
Bug Fixes
Chores
html-entities-decoder) for enhanced label processing.