Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACTIONS & SOURCES] Spotify new actions #1762

Merged
merged 65 commits into from Oct 29, 2021
Merged

[ACTIONS & SOURCES] Spotify new actions #1762

merged 65 commits into from Oct 29, 2021

Conversation

vellames
Copy link
Contributor

@vellames vellames commented Oct 5, 2021

Is there a specific app this action is for?
Spotify

Please provide a link to the relevant API docs for the specific service / operation.
https://developer.spotify.com/documentation/web-api/reference/

Actions

  • Create Playlist | Create a new playlist
  • Save Track | Save a track to "Your Music" library
  • Add Track to Playlist | Add a track to one of your playlists
  • Get Audio Features for Track | Get the audio features (duration, tempo, etc.) for a track
  • Find Track | Look up a track by title/artist or by entering a track ID
  • Artist's Top Tracks | Display artist's top 10 tracks
  • Get List of Category's Playlists in Genres & Moods | Retrieve playlists in each specific category in Genres & Moods
  • Get Playlist's List of Tracks | Retrieve a list of all tracks in a specified playlist
  • Remove Track | Delete the track with the given ID
  • Remove Track from Playlist | Delete the track with the given ID from a playlist

Addictional Improvements

  • Change app from CommonJS to ES Module
  • Change New Playlist Source from CommonJS to ES Module
  • Change New Saved Track Source from CommonJS to ES Module
  • Change New Track In Playlist Source from CommonJS to ES Module
  • Fixed a bug on New Track In Playlist Source. When a user added the same music to a distinct playlists, just one event was triggered

@vercel
Copy link

vercel bot commented Oct 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

pipedream-docs-redirect-do-not-edit – ./docs

🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs-redirect-do-not-edit/8hvWdZmxzAfpbD5LUj5a1BWuwTWz
✅ Preview: https://pipedream-docs-redirect-do-not-edit-git-spo-f5404e-pipedreamers.vercel.app

pipedream-docs – ./docs

🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs/7sn5U6evmVkBZsdyoYGNS8U523Wi
✅ Preview: https://pipedream-docs-git-spotify-new-actions-pipedreamers.vercel.app

@dylburger
Copy link
Contributor

dylburger commented Oct 5, 2021

@vellames vellames changed the title Spotify new actions [ACTIONS ]Spotify new actions Oct 5, 2021
@vellames vellames changed the title [ACTIONS ]Spotify new actions [ACTIONS] Spotify new actions Oct 5, 2021
Copy link
Collaborator

@dannyroosevelt dannyroosevelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it all looks good to me! thanks for all the changes and help, @vellames-turing

Copy link
Contributor

@js07 js07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes and bug fix look good! I just have a few comments.

components/spotify/spotify.app.mjs Outdated Show resolved Hide resolved
components/spotify/spotify.app.mjs Outdated Show resolved Hide resolved
components/spotify/actions/save-track/save-track.mjs Outdated Show resolved Hide resolved
components/spotify/actions/get-track/get-track.mjs Outdated Show resolved Hide resolved
components/spotify/actions/save-track/save-track.mjs Outdated Show resolved Hide resolved
using res.name to surface track name in $summary
Co-authored-by: js07 <19861096+js07@users.noreply.github.com>
@dannyroosevelt
Copy link
Collaborator

@vellames-turing FYI I made 2 of the tweaks Jacob recommended, I'll leave the rest to you

@vellames
Copy link
Contributor Author

@js07 Requests applied

Copy link
Contributor

@js07 js07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for making those changes!

Copy link
Collaborator

@dannyroosevelt dannyroosevelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through a quick test on everything and the only issue I found is that I can't get remove_items_from_playlist to work when I pass in playlist ID with structured mode off.

@vellames
Copy link
Contributor Author

@dannyroosevelt I will take a look on it ASAP

Copy link
Collaborator

@dannyroosevelt dannyroosevelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

@dannyroosevelt
Copy link
Collaborator

@vellames-turing it all looks good to me! merge away 😄

@vellames vellames merged commit 5ef6cdc into master Oct 29, 2021
@vellames vellames deleted the spotify-new-actions branch October 29, 2021 19:24
@vellames vellames mentioned this pull request Nov 26, 2021
60 tasks
@js07 js07 mentioned this pull request Feb 23, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ACTION] Spotify new actions
4 participants