New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACTIONS & SOURCES] Spotify new actions #1762
Conversation
This pull request is being automatically deployed with Vercel (learn more). pipedream-docs-redirect-do-not-edit – ./docs🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs-redirect-do-not-edit/8hvWdZmxzAfpbD5LUj5a1BWuwTWz pipedream-docs – ./docs🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs/7sn5U6evmVkBZsdyoYGNS8U523Wi |
|
components/spotify/actions/add-items-to-playlist/add-items-to-playlist.mjs
Outdated
Show resolved
Hide resolved
components/spotify/actions/add-items-to-playlist/add-items-to-playlist.mjs
Outdated
Show resolved
Hide resolved
components/spotify/actions/add-items-to-playlist/add-items-to-playlist.mjs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it all looks good to me! thanks for all the changes and help, @vellames-turing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes and bug fix look good! I just have a few comments.
using res.name to surface track name in $summary
Co-authored-by: js07 <19861096+js07@users.noreply.github.com>
@vellames-turing FYI I made 2 of the tweaks Jacob recommended, I'll leave the rest to you |
@js07 Requests applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for making those changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran through a quick test on everything and the only issue I found is that I can't get remove_items_from_playlist
to work when I pass in playlist ID with structured mode off.
@dannyroosevelt I will take a look on it ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me!
@vellames-turing it all looks good to me! merge away 😄 |
Is there a specific app this action is for?
Spotify
Please provide a link to the relevant API docs for the specific service / operation.
https://developer.spotify.com/documentation/web-api/reference/
Actions
Addictional Improvements