New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Convert HTML to Markdown Unexpected token '||=' #6220 #6349
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
We had to set a fixed version of JSDOM because the newer version doesn't work with Node 14; Following Pipedream's docs, we imported the package on the code like this: And following this StackOverflow answer https://stackoverflow.com/a/56495651 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing permission to merge - ignore this approval
Was testing permission to merge without all checks passing
@lcaresia what is the status of this? |
@andrewjschuang are working on it |
@dannyroosevelt I'm working with @lcaresia and @alysonturing to see if we can make the GH Action Check pass without ignoring the |
@@ -8,6 +8,7 @@ | |||
"composite": true, | |||
"outDir": "dist", | |||
"allowSyntheticDefaultImports": true, | |||
"skipLibCheck": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was required to use linkedom
package
reference
f4c3e6a
to
62201d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
/approve |
WHAT
🤖 Generated by Copilot at 1824e67
This pull request fixes a dependency issue and updates the convert-html-to-markdown action in the formatting component. It pins the
jsdom
version to 21.1.1 and uses consistent import syntax across the component files.🤖 Generated by Copilot at 1824e67
WHY
HOW
🤖 Generated by Copilot at 1824e67
pnpm-lock.yaml
file (link)