Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Convert HTML to Markdown Unexpected token '||=' #6220 #6349

Merged
merged 1 commit into from May 12, 2023

Conversation

lcaresia
Copy link
Collaborator

@lcaresia lcaresia commented May 8, 2023

WHAT

🤖 Generated by Copilot at 1824e67

This pull request fixes a dependency issue and updates the convert-html-to-markdown action in the formatting component. It pins the jsdom version to 21.1.1 and uses consistent import syntax across the component files.

🤖 Generated by Copilot at 1824e67

Oh we're the crew of the formatting ship, and we work with code and yarn
We've pinned the jsdom to twenty-one, and we've raised the action barn
Heave away, me hearties, heave away with me
We've fixed the dependency issue, and we've made the markdown free

WHY

HOW

🤖 Generated by Copilot at 1824e67

  • Update jsdom dependency to 21.1.1 and use alias syntax to avoid conflict with other components (link, link, link, link, link)
  • Remove unused omniconvert component from pnpm-lock.yaml file (link)

@lcaresia lcaresia added the bug Something isn't working label May 8, 2023
@vercel
Copy link

vercel bot commented May 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pipedream-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 4:09pm
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 4:09pm

@lcaresia lcaresia linked an issue May 8, 2023 that may be closed by this pull request
@alysonturing
Copy link
Contributor

alysonturing commented May 8, 2023

We had to set a fixed version of JSDOM because the newer version doesn't work with Node 14;

Following Pipedream's docs, we imported the package on the code like this:
import jsdom from "jsdom@21.1.1";

And following this StackOverflow answer https://stackoverflow.com/a/56495651
We used an alias for the import on the package.json like this:
"jsdom@21.1.1": "npm:jsdom@21.1.1",

Result:
Captura de Tela 2023-05-08 às 13 55 20
Captura de Tela 2023-05-08 às 13 55 07

GTFalcao
GTFalcao previously approved these changes May 8, 2023
Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing permission to merge - ignore this approval

@dannyroosevelt
Copy link
Collaborator

@lcaresia what is the status of this?

@lcaresia
Copy link
Collaborator Author

@lcaresia what is the status of this?

@andrewjschuang are working on it

@andrewjschuang
Copy link
Collaborator

@dannyroosevelt I'm working with @lcaresia and @alysonturing to see if we can make the GH Action Check pass without ignoring the pnpm cache so the workflow time execution is not compromised. We are doing this to enable the usage of pinned versions of npm packages.

@@ -8,6 +8,7 @@
"composite": true,
"outDir": "dist",
"allowSyntheticDefaultImports": true,
"skipLibCheck": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was required to use linkedom package
reference

@PipedreamHQ PipedreamHQ deleted a comment from alysonturing May 10, 2023
Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vunguyenhung
Copy link
Collaborator

Hi, I see that the bug is fixed
image

@lcaresia
Copy link
Collaborator Author

/approve

@lcaresia lcaresia merged commit 8fbdfee into master May 12, 2023
10 checks passed
@lcaresia lcaresia deleted the html-to-markdown branch May 12, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Convert HTML to Markdown Unexpected token '||='
6 participants