Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugxfix] Snowflake - Failed Task in Schema #6712

Merged
merged 7 commits into from
Jun 1, 2023

Conversation

vellames
Copy link
Contributor

@vellames vellames commented May 31, 2023

WHAT

🤖 Generated by Copilot at 28c3a81

This pull request updates the snowflake package with various minor changes and bug fixes for the components, actions, and sources. It also adds new dependencies for ip2location_io and mem components. The most significant change is the improvement of the task history source, which now uses the current time as the max timestamp and the INFORMATION_SCHEMA.TASK_HISTORY table function.

🤖 Generated by Copilot at 28c3a81

We are the masters of the snowflake
We fix the bugs and make it break
We query fast and store the history
We know the secrets of the mystery

WHY

HOW

🤖 Generated by Copilot at 28c3a81

  • Incremented the version of the snowflake package and all its components to reflect minor changes or bug fixes (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Improved the SQL query for retrieving failed tasks in a schema by using the INFORMATION_SCHEMA.TASK_HISTORY table function with parameters (link)
  • Removed the unnecessary code for getting the new max timestamp of the task history and changed the code for setting the last max timestamp to use Date.now() (link, link)
  • Added the ip2location_io and mem components as dependencies in the pnpm-lock.yaml file (link, link)

@vellames vellames self-assigned this May 31, 2023
@vercel
Copy link

vercel bot commented May 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pipedream-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 3:36pm
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 3:36pm

@vellames vellames added this to Ready for PR review in Component (Source and Action) Backlog May 31, 2023
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label May 31, 2023
Copy link
Collaborator

@michelle0927 michelle0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ready for QA!

@michelle0927 michelle0927 moved this from In Review to Ready for QA in Component (Source and Action) Backlog May 31, 2023
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Jun 1, 2023
@vunguyenhung
Copy link
Collaborator

Hi, I'm not sure how to reproduce the bug. Though I have tested and observed that the events emitted correctly, so I'll move this to ready for release
image

@vunguyenhung vunguyenhung moved this from In QA to Ready for release in Component (Source and Action) Backlog Jun 1, 2023
@vellames vellames merged commit d566529 into master Jun 1, 2023
10 checks passed
@vellames vellames deleted the bugfix/snowflake-query-failed-story branch June 1, 2023 17:00
@michelle0927 michelle0927 moved this from Ready for release to Done in Component (Source and Action) Backlog Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee
Development

Successfully merging this pull request may close these issues.

None yet

4 participants