[Source] Snowflake - Add regex to getFailedTasksInDatabase #6736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dylburger
added
the
triaged
vellames
changed the title
michelle0927
moved this from Ready for PR review
to In Review
in Component (Source and Action) Backlog
michelle0927
previously approved these changes
Jun 1, 2023
michelle0927
moved this from In Review
to Ready for QA
in Component (Source and Action) Backlog
vunguyenhung
moved this from Ready for QA
to In QA
in Component (Source and Action) Backlog
|
Hello everyone, I have re-tested this PR and there's still a test cases failed. Please check the test report below for more information |
vunguyenhung
moved this from In QA
to Changes Required
in Component (Source and Action) Backlog
|
Closes #5867 |
…to feature/regex-snowflake-5867
|
@vunguyenhung Fixed. Also, I used this PR to make schema be an array |
alysonturing
approved these changes
Jun 5, 2023
michelle0927
approved these changes
Jun 5, 2023
|
Hi everyone, all test cases are passed! Ready for release! Test report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at f3c7be6
This pull request updates the snowflake package to version 0.9.1, which includes minor changes and bug fixes for several actions and sources related to snowflake. It also adds a new prop to the failed-task-in-schema source to filter failed tasks by name using regex, and refactors the common module of the snowflake sources to use helper methods for getting and setting the last max timestamp from the database. Additionally, it improves the performance and accuracy of the getFailedTasksInDatabase method of the snowflake app by using the INFORMATION_SCHEMA.TASK_HISTORY table function with some additional parameters.
🤖 Generated by Copilot at f3c7be6
WHY
HOW
🤖 Generated by Copilot at f3c7be6
failed-task-in-schemasource to allow filtering the failed tasks by a regex pattern (link)snowflake.app.mjsfile to accept the taskName parameter and use the INFORMATION_SCHEMA.TASK_HISTORY table function with additional parameters for performance and accuracy (link)common.mjsmodule to abstract the logic of getting and setting the last max timestamp from the database (link)common.mjsmodule to use the _getLastMaxTimestamp and _setLastMaxTimestamp methods instead of directly accessing the database, and to pass the taskName parameter to the getFailedTasksInDatabase method (link, link, link)