Update new-contact-property-change.mjs #8462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slack Discussion: https://pipedream-users.slack.com/archives/CMZG4EBJ9/p1697210929916869 https://api.hubapi.com/crm/v3/objects/contacts/batch/read can only accept 50 inputs per call. If there are more than 50 contacts, it will fail with the following message: "The maximum number of inputs supported in a batch request for property histories is 50. Please reduce the number of items and try again" The code loops over the Contact IDs and limits the inputs to less than 50.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dylburger
added
the
triaged
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
|
You need to bump the version of the component that you enhanced and the package.json too |
alysonturing
moved this from Ready for PR review
to Changes Required
in Component (Source and Action) Backlog
alysonturing
suggested changes
Oct 16, 2023
michelle0927
moved this from Changes Required
to Ready for PR review
in Component (Source and Action) Backlog
michelle0927
approved these changes
Nov 21, 2023
michelle0927
moved this from Ready for PR review
to Ready for QA
in Component (Source and Action) Backlog
vunguyenhung
moved this from Ready for QA
to In QA
in Component (Source and Action) Backlog
vunguyenhung
moved this from In QA
to Ready for release
in Component (Source and Action) Backlog
|
Hi everyone, all test cases are passed! Ready for release! |
michelle0927
moved this from Ready for release
to Done
in Component (Source and Action) Backlog
Ahmad-anility
pushed a commit
to Anility/pipedream-anility
that referenced
this pull request
Jan 3, 2024
* Update new-contact-property-change.mjs Slack Discussion: https://pipedream-users.slack.com/archives/CMZG4EBJ9/p1697210929916869 https://api.hubapi.com/crm/v3/objects/contacts/batch/read can only accept 50 inputs per call. If there are more than 50 contacts, it will fail with the following message: "The maximum number of inputs supported in a batch request for property histories is 50. Please reduce the number of items and try again" The code loops over the Contact IDs and limits the inputs to less than 50. * bump versions * package.json --------- Co-authored-by: michelle0927 <michellelbergero@hotmail.com> Co-authored-by: michelle0927 <michelle0927@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack Discussion: https://pipedream-users.slack.com/archives/CMZG4EBJ9/p1697210929916869
https://api.hubapi.com/crm/v3/objects/contacts/batch/read can only accept 50 inputs per call. If there are more than 50 contacts, it will fail with the following message:
"The maximum number of inputs supported in a batch request for property histories is 50. Please reduce the number of items and try again"
The code loops over the Contact IDs and limits the inputs to less than 50.
WHAT
🤖 Generated by Copilot at 3741e30
Improved the performance and reliability of the
new-contact-property-changesource by processing the updated contacts in batches. Added abatchSizevariable and a for loop tonew-contact-property-change.mjsto implement the batching logic.🤖 Generated by Copilot at 3741e30
WHY
Fixes bug whereby the workflow will fail if there are more than 50 Contacts in the BATCH API call
HOW
🤖 Generated by Copilot at 3741e30