A bit of cleanup #2
Conversation
|
Ignore the large diff count, that is just |
|
I've also added more CRUD support here. |
dylanegan
force-pushed
the
a-bit-of-cleanup
branch
from
f1ebca8
to
a16703c
Compare
|
@aossowski shall we merge this to master and maybe publish to NPM? |
|
@dylanegan we can merge to master but I think too many resources are still missing there to publish it |
|
Is that an issue? If it's pre-1.0.0 I wouldn't expect feature parity. |
| @@ -27,6 +27,7 @@ | |||
| "test": "./node_modules/karma/bin/karma start --single-run" | |||
| }, | |||
| "devDependencies": { | |||
| "babel-cli": "^6.18.0", | |||
There was a problem hiding this comment.
What was the requirement here?
There was a problem hiding this comment.
npm run build didn't work without it
There was a problem hiding this comment.
What was the output without it?
There was a problem hiding this comment.
babel: command not found ;-)
There was a problem hiding this comment.
@aossowski no problem, was able to replicate. I must've done nom install -g babel-cli as some point on my old machine as my new machine failed immediately. Thanks!
| } | ||
|
|
||
| get () { | ||
| return this.__client.request(this.__urlFor('')) |
There was a problem hiding this comment.
Should be able to call it without the argument here.
|
@aossowski do you foresee any additional endpoints we'll need for Reporting or would this be safe to merge in and move things to using it? |
|
@dylanegan we will need more endpoints to save/retrieve reports and export data but we can add it later as separate PRs |
This is just to clean things up a bit as there were remnants from the Zendesk code that wasn't necessary for this library.
Also the specifications weren't running properly, so I've fixed those to run properly now.