Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct messages API calls #41

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #41 into master will increase coverage by 0.26%.
The diff coverage is 86.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   85.84%   86.11%   +0.26%     
==========================================
  Files          19       24       +5     
  Lines         318      425     +107     
==========================================
+ Hits          273      366      +93     
- Misses         45       59      +14
Impacted Files Coverage Δ
rocketchat/calls/im/open_room.py 75% <75%> (ø)
rocketchat/calls/im/close_room.py 75% <75%> (ø)
rocketchat/api.py 89.04% <86.66%> (-0.62%) ⬇️
rocketchat/calls/im/get_history.py 90.9% <90.9%> (ø)
rocketchat/calls/im/create_room.py 90.9% <90.9%> (ø)
rocketchat/calls/im/get_rooms.py 91.66% <91.66%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef1cebe...f32926c. Read the comment docs.

Copy link
Member

@pipozzz pipozzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@pipozzz
Copy link
Member

pipozzz commented Nov 22, 2019

Thank you very much for contribution !

@pipozzz pipozzz merged commit 80ce66f into Pipoline:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants