Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field settings for regions are not always provided in JSON #1958

Closed
andyjwwhite opened this issue Nov 14, 2022 · 0 comments · Fixed by #1960
Closed

Field settings for regions are not always provided in JSON #1958

andyjwwhite opened this issue Nov 14, 2022 · 0 comments · Fixed by #1960
Assignees
@andyjwwhite
Labels
bug core-manager
Milestone
Version 10.3

Comments

@andyjwwhite
Copy link
Contributor

There are a number of scenarios where field settings provided by FieldSettingsAttributes will not be output in the edit model JSON API responses:

  • Regions in posts
  • Regions that are part of a list
  • Regions in site content

Looks like the settings are not being copied across from the underlying ContentTypeField objects in ContentTypeService, PostService and SiteService.
@tidyui tidyui added this to the Version 10.3 milestone Nov 14, 2022
hnegus1 pushed a commit to soundintheory/piranha.core that referenced this issue Nov 14, 2022
@sit-harry
Provide field settings for regions for the cases in PiranhaCMS#1958
724b009
@andyjwwhite andyjwwhite mentioned this issue Nov 15, 2022
Merged
@tidyui tidyui changed the title Field settings for regions are not always provided to field components Field settings for regions are not always provided in JSON Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyjwwhite andyjwwhite

Labels
bug core-manager
Projects
None yet
Milestone
Version 10.3
Development

Successfully merging a pull request may close this issue.

Provide field settings for regions for the cases in #1958 soundintheory/piranha.core
2 participants
@tidyui @andyjwwhite