Added net7.0 along side net6.0 support #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed global.json sdk to 7.0.302 - added multiple targetframewords net6.0 + net7.0 - extracted Microsoft.SourceLink.GitHub reference up to build.targets - updated github actions with dotnet version 7.0.x
|
@dotnet-policy-service agree |
|
Hi all, My reasoning behind this PR is that dotnet 7 support opens up a lot of minimal API features for headless projects and I would love to be able to upgrade my CMS project. At the moment I cannot do that due to EFCore breaking on dotnet7. With dotnet8 around the corner it could help provide a starting point for multiple TFM support. Regards, C. |
|
Great! Will take a look and try it out and see how NuGet packages are generated |
tidyui
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the comment by @tidyui in a previous pull request #1983 I added support both for dotnet 6.0 and dotnet 7.0 so that it can be delivered as a patch release.
All tests pass both on dotnet versions.
I had occasional transient error popup regarding concurrent runs of the
Piranha.Tests.ImageSharp.MediaServiceTests.GetCroppedbecause the same tests run in both frameworks.