Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend max length of Post Excerpt #2039

Merged

Conversation

kimlundjohansen
Copy link
Contributor

This PR introduces extended lengths for the excerpt, meta title and meta description fields. The database schema supports it, so I see no reason to limit the UI input lengths.

@kimlundjohansen
Copy link
Contributor Author

kimlundjohansen commented Jan 5, 2024 via email

@tidyui
Copy link
Member

tidyui commented Jan 8, 2024

Borg meta titel & description have max lengths set in the database schema which would need to be updated as well to support the behavior. Also please note that the current max length of these fields are already set to twice the recommended max length given how these fields are used by search engines, so I don’t really see the value of increasing them even more other than if your planning on using these fields for other information than they were intended for.

Regards

@kimlundjohansen
Copy link
Contributor Author

Fair point. I have reverted the meta title and description changes. Would you be ok with excerpt change?

@kimlundjohansen
Copy link
Contributor Author

Would you be ok with excerpt change?

@tidyui tidyui changed the title feat: Extend excerpt, meta title and meta description Extend max length of Excerpt Mar 6, 2024
@tidyui tidyui changed the title Extend max length of Excerpt Extend max length of Post Excerpt Mar 6, 2024
@tidyui tidyui merged commit caa019c into PiranhaCMS:master Mar 6, 2024
3 checks passed
@tidyui
Copy link
Member

tidyui commented Mar 6, 2024

Please note, also did the same change for pages and added char count to textbooks. See #2049

@kimlundjohansen kimlundjohansen deleted the features/extend-excerpt-field branch March 6, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants