-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional type system - complain if proven wrong #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added some types to syntax - Added “types” module - Added `types::Type` - Added `Type::goes_with`
- Renamed “types” module to “typecheck” - Added `Type::description` - Added `Type::array` - Added `Type::object` - Added `Type::option` - Added `Type::result` - Fixed `Type::goes_with` - Added syntax for optional space before and after arguments - Added syntax for returning type - Added types to snake example - Added types to n_body benchmark - Added type check test for opt - Added type information to intrinsic functions - Don’t panic on unknown kind in lifetime checker - Added `PreludeFunction::tys`
Fixed some bugs in type checker
- Fixed syntax tests - Added “typechk/return_3” - Moved type checking from AST to lifetime checker graph
- Removed unused imports - Fixed syntax tests - Added “typechk/return_4” - Change kind to `ReturnVoid`
- Set return type of mathematically declared functions to `Any` - Added “typechk/add.rs” - Added “typechk/mat_expr.rs” - Require type from all children of Add nodes
- Added “item_extra” to meta syntax to help type checker - Added “typechk/call.rs” - Added “typechk/obj.rs”
This is just very basic type checking, but merging because it seem to work reasonably well and the more advanced stuff needs tweaking over longer time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #80
This PR adds an optional type system using a similar, but different syntax than Rust.
bool
(boolean)f64
(number)vec4
(4D vector)[]
/[T]
(array){}
(object)opt[T]
(option)res[T]
(result)any
(any type, exceptvoid
)void
(no value type)Example
Any
An
any
type works with any other type exceptvoid
.Non-guarantee of argument type inside function body
Consider a simple example like this:
It is not guaranteed that
a
has the typebool
inside the function body. This is because the function can be called with an argument that is inferred toany
at type checking.Performance
The runtime performance should not be affected significantly, but the loading will take a little extra time.